Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] When adding tags in tag management, random colors are given by default. #1386

Closed
m01i0ng opened this issue Dec 5, 2023 · 5 comments · Fixed by #1412
Closed

[Task] When adding tags in tag management, random colors are given by default. #1386

m01i0ng opened this issue Dec 5, 2023 · 5 comments · Fixed by #1412
Assignees
@prolevel1
Labels
good first issue Good for newcomers help wanted Extra attention is needed status: volunteer wanted task

Comments

@m01i0ng
Copy link

m01i0ng commented Dec 5, 2023

Description

标签量比较大的话选颜色是一个头疼的问题，可以默认随机一个颜色
image

Task List

No response
@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Description

If the number of labels is relatively large, choosing a color is a headache. You can default to a random color.
image

Task List

No response

@hertzbeat hertzbeat changed the title [Task] 标签管理增加标签时，默认给于随机颜色 [Task] When adding tags in tag management, random colors are given by default. Dec 5, 2023
@tomsun28 tomsun28 added good first issue Good for newcomers help wanted Extra attention is needed task labels Dec 5, 2023
@prolevel1
Copy link
Contributor

I would like to help

@tomsun28
Copy link
Contributor

tomsun28 commented Dec 8, 2023

I would like to help

welcome. this has assigned to you.
suggest edit code here. https://github.com/dromara/hertzbeat/blob/master/web-app/src/app/routes/setting/tags/tags.component.ts#L149
addthis.tag.color = randomxxx when add a new tag

@prolevel1
Copy link
Contributor

Hi @tomsun28 please review this PR: #1412

@tomsun28 tomsun28 linked a pull request Dec 9, 2023 that will close this issue
[Task-1386] When adding tags in tag management, random colors are given by default. #1412
Merged
5 tasks
@tomsun28
Copy link
Contributor

tomsun28 commented Dec 9, 2023

Hi @tomsun28 please review this PR: #1412

ok👍👍

@github-project-automation github-project-automation bot moved this from To do to Done in hertzbeat-v1.0 Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prolevel1 prolevel1

Labels
good first issue Good for newcomers help wanted Extra attention is needed status: volunteer wanted task
Projects
None yet
Milestone
No milestone
4 participants
@m01i0ng @tomsun28 @prolevel1 @hertzbeat