[Task-1386] When adding tags in tag management, random colors are given by default. #1412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsun28
added
enhancement
tomsun28
approved these changes
Dec 9, 2023
There was a problem hiding this comment.
LGTM👍👍 and please fix the eslint code warning.
/home/runner/work/hertzbeat/hertzbeat/web-app/src/app/pojo/Tag.ts
14:12 error Unexpected string concatenation prefer-template
✖ 1 problem (1 error, 0 warnings)
Lint errors found in the listed files.
1 error and 0 warnings potentially fixable with the `--fix` option.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Process completed with exit code 1.
|
@all-contributors please add @prolevel1 for code |
tomsun28
pushed a commit
that referenced
this pull request
Jan 16, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Whenever we add a new tag from a the Tag Management, a random color will be given by default to that Tag
Checklist
Add or update API