-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support query monitors by tags filter #1013
Conversation
Hi @tomsun28 ,I have modified the backend codes, maybe need some guys to modify frontend code |
用标签来进行分组怎么样,我们有标签功能,用户给监控打上特定的一类标签,然后用标签来查询过滤一组监控 |
How about grouping with tags? We have a tagging function. Users can tag a specific category of monitors, and then use tags to query and filter a group of monitors. |
我觉得不错,hhh |
I feel good, hhh |
Hi,那后端接受的param是list呢还是一个json字符串? |
Hi, is the param accepted by the backend a list or a json string? |
标签数组吧,就是我们的监控查询支持一波 根据标签过滤查询 |
Label array, that is, our monitoring query supports a wave of filtering queries based on labels |
Hi @tomsun28 ,I have modified the code to support group by tag and query by tag list, you can review |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍👍
What's changed?
add monitorGroup in
Monitor
and modify query API to support group monitorChecklist