Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: aviator fn for str contains, exists & matches #1106

Merged
merged 2 commits into from
Jul 19, 2023
Merged

feat: aviator fn for str contains, exists & matches #1106

merged 2 commits into from
Jul 19, 2023

Conversation

mikezzb
Copy link
Contributor

@mikezzb mikezzb commented Jul 19, 2023

What's changed?

Implemented custom functions to support alert threshold computation:

  • contains(str1,str2)
  • exists("keyName")
  • matches(str,"regex")

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Jul 19, 2023
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomsun28
Copy link
Contributor

@all-contributors please add @mikezzb for code

@allcontributors
Copy link
Contributor

@tomsun28

I've put up a pull request to add @mikezzb! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants