New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

monitoring param host with http head will not be error reported #1155

Merged

tomsun28 merged 8 commits into apache:master from littlezhongzer:loyal_dev

Aug 8, 2023

Contributor

littlezhongzer commented Aug 5, 2023

What's changed?

feature:enter the domain name in host, including http://or https://, and there will be no error reported

Checklist

I have read the Contributing Guide
I have written the necessary doc or comment.
I have added the necessary unit tests and all cases have passed.

zhongcheng added 2 commits

July 21, 2023 16:01


          feature:monitor brearer token api, ignore letter case to comparison

dab18bd


          feature:enter the domain name in host, including http://or https://, …

eacf380

…and there will be no error reported

tomsun28 added enhancement good first pull request labels

Contributor

tomsun28 commented Aug 5, 2023

👍👍 hi we need to consider this situation https://hertzbeat.com/, there is a / character at the end


          Merge branch 'dromara:master' into loyal_dev

Contributor

tomsun28 commented Aug 8, 2023

hi, there has code pmd error, please fix it

[INFO] PMD Failure: org.dromara.hertzbeat.common.support.valid.HostParamValidator:35 Rule:UndefineMagicConstantRule Priority:3 魔法值【"http://"】.
[INFO] PMD Failure: org.dromara.hertzbeat.common.support.valid.HostParamValidator:38 Rule:UndefineMagicConstantRule Priority:3 魔法值【"https://"】.

tomsun28 changed the title ~~Loyal dev~~ monitoring param host with http head will not be error reported

littlezhongzer closed this

littlezhongzer deleted the loyal_dev branch

August 8, 2023 09:21

littlezhongzer restored the loyal_dev branch

August 8, 2023 09:36

littlezhongzer reopened this

zhongcheng added 2 commits

August 8, 2023 17:41


          monitoring param host with http head will not be error reported

d019c04


          change notice info when input host with / character at the end

934c511

tomsun28 approved these changes

View reviewed changes

Contributor

tomsun28 left a comment

LGTM👍👍

tomsun28 reviewed

View reviewed changes

common/src/main/java/org/dromara/hertzbeat/common/support/valid/HostParamValidator.java Outdated Show resolved Hide resolved

tomsun28 reviewed

View reviewed changes

common/src/main/java/org/dromara/hertzbeat/common/support/valid/HostParamValidator.java Outdated Show resolved Hide resolved

tomsun28 reviewed

View reviewed changes

manager/src/main/java/org/dromara/hertzbeat/manager/service/impl/MonitorServiceImpl.java Outdated Show resolved Hide resolved

tomsun28 reviewed

View reviewed changes

common/src/main/java/org/dromara/hertzbeat/common/support/valid/HostParamValidator.java Outdated Show resolved Hide resolved


          Apply suggestions from code review

56c4410

Signed-off-by: tomsun28 <tomsun28@outlook.com>

tomsun28 reviewed

View reviewed changes

common/src/main/java/org/dromara/hertzbeat/common/support/valid/HostValid.java Outdated Show resolved Hide resolved


          Update common/src/main/java/org/dromara/hertzbeat/common/support/vali…

da2ebfb

…d/HostValid.java

Signed-off-by: tomsun28 <tomsun28@outlook.com>

tomsun28 reviewed

View reviewed changes

common/src/main/java/org/dromara/hertzbeat/common/support/valid/HostParamValidator.java Outdated Show resolved Hide resolved

tomsun28 reviewed

View reviewed changes

manager/src/main/java/org/dromara/hertzbeat/manager/service/impl/MonitorServiceImpl.java Outdated Show resolved Hide resolved

tomsun28 reviewed

View reviewed changes

manager/src/main/java/org/dromara/hertzbeat/manager/service/impl/MonitorServiceImpl.java Outdated Show resolved Hide resolved


          fix pmd error

1b1dc32

Signed-off-by: tomsun28 <tomsun28@outlook.com>

tomsun28 merged commit 6fb84f0 into apache:master

2 checks passed

tomsun28 pushed a commit that referenced this pull request


          monitoring param host with http head will not be error reported (#1155)

f146ebc

Co-authored-by: zhongcheng <zhongcheng@winning.com.cn>

tomsun28 pushed a commit that referenced this pull request


          monitoring param host with http head will not be error reported (#1155)

25ebf59

Co-authored-by: zhongcheng <zhongcheng@winning.com.cn>

tomsun28 pushed a commit that referenced this pull request


          monitoring param host with http head will not be error reported (#1155)

dffc31b

Co-authored-by: zhongcheng <zhongcheng@winning.com.cn>

tomsun28 pushed a commit that referenced this pull request


          monitoring param host with http head will not be error reported (#1155)

96339f7

Co-authored-by: zhongcheng <zhongcheng@winning.com.cn>

tomsun28 pushed a commit that referenced this pull request


          monitoring param host with http head will not be error reported (#1155)

6428c31

Co-authored-by: zhongcheng <zhongcheng@winning.com.cn>

tomsun28 pushed a commit that referenced this pull request


          monitoring param host with http head will not be error reported (#1155)

c3f211f

Co-authored-by: zhongcheng <zhongcheng@winning.com.cn>

tomsun28 pushed a commit that referenced this pull request


          monitoring param host with http head will not be error reported (#1155)

7c72f23

Co-authored-by: zhongcheng <zhongcheng@winning.com.cn>

tomsun28 pushed a commit that referenced this pull request


          monitoring param host with http head will not be error reported (#1155)

40ad797

Co-authored-by: zhongcheng <zhongcheng@winning.com.cn>

tomsun28 pushed a commit that referenced this pull request


          monitoring param host with http head will not be error reported (#1155)

8c6120e

Co-authored-by: zhongcheng <zhongcheng@winning.com.cn>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement good first pull request