Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support monitor metrics name i18n #1198

Merged
merged 9 commits into from
Aug 23, 2023
Merged

support monitor metrics name i18n #1198

merged 9 commits into from
Aug 23, 2023

Conversation

tomsun28
Copy link
Contributor

What's changed?

support monitor metrics name i18n

image image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request new feature labels Aug 22, 2023
@@ -396,19 +506,34 @@ metrics:
parseType: multiRow

- name: top_mem_process
i18n:
zh-CN: Top10 内存进程
en-US: Total10 Memory Process
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top_mem_process是否需要改名字?命令是查询进程信息,除了内存还有CPU
Total10改为Top10,保持统一

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的, top_mem_process 是以内存排序,上面那个 top_cpu_process 是以CPU排序

Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@tomsun28 tomsun28 merged commit 3dd1e16 into master Aug 23, 2023
2 checks passed
@tomsun28 tomsun28 deleted the metrics-i18n branch August 23, 2023 06:29
tomsun28 added a commit that referenced this pull request Jan 16, 2024
tomsun28 added a commit that referenced this pull request Mar 9, 2024
tomsun28 added a commit that referenced this pull request Mar 9, 2024
tomsun28 added a commit that referenced this pull request Mar 10, 2024
tomsun28 added a commit that referenced this pull request Mar 10, 2024
tomsun28 added a commit that referenced this pull request Mar 11, 2024
tomsun28 added a commit that referenced this pull request Mar 11, 2024
tomsun28 added a commit that referenced this pull request Mar 11, 2024
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants