Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ospp] support ui help massage component #1199

Merged
merged 6 commits into from
Aug 22, 2023
Merged

Conversation

FanTuanCat
Copy link
Contributor

What's changed?

Updates the help component functions and merge the help_massage_compoment_dev to master.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
…ge_component_dev

Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@tomsun28
Copy link
Contributor

👍👍 Great!
hi, there are some eslint error

/home/runner/work/hertzbeat/hertzbeat/web-app/src/app/shared/shared.module.ts
  13:1  error  There should be at least one empty line between import groups                                                                 import/order
  14:1  error  `ng-zorro-antd/breadcrumb` import should occur before import of `./components/help-massage-show/help-massage-show.component`  import/order
  14:9  error  Replace `NzBreadCrumbModule}·from·"ng-zorro-antd/breadcrumb"` with `·NzBreadCrumbModule·}·from·'ng-zorro-antd/breadcrumb'`    prettier/prettier
  15:1  error  `ng-zorro-antd/tag` import should occur before import of `./components/help-massage-show/help-massage-show.component`         import/order
  15:9  error  Replace `NzTagModule}·from·"ng-zorro-antd/tag";⏎` with `·NzTagModule·}·from·'ng-zorro-antd/tag';`                             prettier/prettier

you can run yarn lint:fix in web-app to fix it.

image

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature labels Aug 22, 2023
@tomsun28 tomsun28 changed the title Help massage component dev [ospp] support ui help massage component Aug 22, 2023
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍 LGTM!

@FanTuanCat FanTuanCat merged commit 9577601 into master Aug 22, 2023
2 checks passed
@tomsun28 tomsun28 deleted the help_massage_component_dev branch August 22, 2023 07:46
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Signed-off-by: Yuting Nie <yvettemisaki@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants