Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor code and fix some npe #1201

Merged
merged 5 commits into from
Aug 23, 2023
Merged

refactor code and fix some npe #1201

merged 5 commits into from
Aug 23, 2023

Conversation

Carpe-Wang
Copy link
Contributor

@Carpe-Wang Carpe-Wang commented Aug 22, 2023

What's changed?

简化,以及修一些潜在的空指针
new BigDecimal((Double) o * 1000) 修改为 BigDecimal.valueOf((Double) o * 1000) 减少频繁的运算中导致内存浪费

利用 try-with-resources删除finally代码块

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28 tomsun28 changed the title 简化,以及修一些潜在的空指针 refactor code and fix some npe Aug 23, 2023
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@Carpe-Wang Carpe-Wang merged commit 5d7909c into master Aug 23, 2023
2 checks passed
@Carpe-Wang Carpe-Wang deleted the 822dev branch August 23, 2023 11:42
tomsun28 added a commit that referenced this pull request Jan 16, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants