Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature]Add getAlertDefinesByName. #1237

Merged
merged 1 commit into from
Sep 9, 2023
Merged

[feature]Add getAlertDefinesByName. #1237

merged 1 commit into from
Sep 9, 2023

Conversation

zqr10159
Copy link
Member

@zqr10159 zqr10159 commented Sep 8, 2023

What's changed?

Add getAlertDefinesByName.
#1230

image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature labels Sep 9, 2023
@tomsun28 tomsun28 linked an issue Sep 9, 2023 that may be closed by this pull request
[Task] <title>Threshold rule function has no query condition #1230
Closed
tomsun28
tomsun28 approved these changes Sep 9, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍👍👍！

@tomsun28 tomsun28 merged commit d4b918f into apache:master Sep 9, 2023
2 checks passed
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@zqr10159 @tomsun28
[feature] add threshold rule query condition. (#1237)
1a58ec1
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@zqr10159
[feature] add threshold rule query condition. (#1237)
588e113
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@zqr10159
[feature] add threshold rule query condition. (#1237)
0c7cd23
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@zqr10159
[feature] add threshold rule query condition. (#1237)
acd2699
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@zqr10159 @tomsun28
[feature] add threshold rule query condition. (#1237)
c91a779
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@zqr10159
[feature] add threshold rule query condition. (#1237)
52297eb
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@zqr10159
[feature] add threshold rule query condition. (#1237)
aab8cf4
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@zqr10159
[feature] add threshold rule query condition. (#1237)
d285d6f
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@zqr10159
[feature] add threshold rule query condition. (#1237)
76d5044
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] <title>Threshold rule function has no query condition
2 participants
@zqr10159 @tomsun28