Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netty as an independent module, add new feature about collector list #1244

Merged
merged 48 commits into from
Sep 14, 2023

Conversation

Ceilzcx
Copy link
Contributor

@Ceilzcx Ceilzcx commented Sep 12, 2023

What's changed?

#1194

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

…_1194_collector

# Conflicts:
#	collector/src/main/java/org/dromara/hertzbeat/collector/dispatch/CommonDispatcher.java
@Ceilzcx Ceilzcx linked an issue Sep 12, 2023 that may be closed by this pull request
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers task labels Sep 12, 2023
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@tomsun28 tomsun28 merged commit 032168d into master Sep 14, 2023
2 checks passed
@tomsun28 tomsun28 deleted the issue_1194_collector branch September 14, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers new feature task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] <About managing collector cluster management>
2 participants