Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] Use static methods instead of constructors for Message.java #1247

Merged
merged 3 commits into from
Sep 13, 2023
Merged

[Refactor] Use static methods instead of constructors for Message.java #1247

merged 3 commits into from
Sep 13, 2023

Conversation

gcdd1993
Copy link
Contributor

What's changed?

  • Use static methods instead of constructors for Message.java
  • Use A.isEmpty() instead of "".equals(A)

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@gcdd1993 gcdd1993 self-assigned this Sep 13, 2023
tomsun28
tomsun28 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Sep 13, 2023
@tomsun28 tomsun28 merged commit bf5d875 into master Sep 13, 2023
2 checks passed
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@gcdd1993 @tomsun28
[Refactor] Use static methods instead of constructors for Message.java (
b960fea 
#1247)

Co-authored-by: Musk.Chen <Musk.Chen@fanruan.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@gcdd1993
[Refactor] Use static methods instead of constructors for Message.java (
e546dc3 
#1247)

Co-authored-by: Musk.Chen <Musk.Chen@fanruan.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@gcdd1993
[Refactor] Use static methods instead of constructors for Message.java (
c440e4f 
#1247)

Co-authored-by: Musk.Chen <Musk.Chen@fanruan.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@gcdd1993
[Refactor] Use static methods instead of constructors for Message.java (
2eeaf7e 
#1247)

Co-authored-by: Musk.Chen <Musk.Chen@fanruan.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@gcdd1993 @tomsun28
[Refactor] Use static methods instead of constructors for Message.java (
f2d2658 
#1247)

Co-authored-by: Musk.Chen <Musk.Chen@fanruan.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@gcdd1993
[Refactor] Use static methods instead of constructors for Message.java (
4acf981 
#1247)

Co-authored-by: Musk.Chen <Musk.Chen@fanruan.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@gcdd1993
[Refactor] Use static methods instead of constructors for Message.java (
45bc5de 
#1247)

Co-authored-by: Musk.Chen <Musk.Chen@fanruan.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@gcdd1993
[Refactor] Use static methods instead of constructors for Message.java (
c0cb67c 
#1247)

Co-authored-by: Musk.Chen <Musk.Chen@fanruan.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@gcdd1993
[Refactor] Use static methods instead of constructors for Message.java (
b063069 
#1247)

Co-authored-by: Musk.Chen <Musk.Chen@fanruan.com>
@tomsun28 tomsun28 deleted the refactor#messagewrapper branch March 11, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees

@gcdd1993 gcdd1993

Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gcdd1993 @tomsun28