Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix jmx memory_pool unit and time unit error #1273

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Conversation

rbsrcy
Copy link
Contributor

@rbsrcy rbsrcy commented Oct 8, 2023

What's changed?

修改memory_pool下指标单位,改为用MB(有个重复的pr注意下
修复thread下CurrentThreadUserTime与CurrentThreadCpuTime两个指标单位不正确问题,支持纳秒自动转化秒

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers bugfix labels Oct 8, 2023
@tomsun28 tomsun28 changed the title Dev bugfix jmx memory_pool unit and time unit error Oct 8, 2023
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍👍

@tomsun28 tomsun28 merged commit 2bd8884 into apache:master Oct 9, 2023
2 checks passed
@tomsun28 tomsun28 added this to the v1.4.2 milestone Oct 9, 2023
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: zhuoshangyi <zhuoshangyi@hntradesp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants