Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the test waiting for server and client start #1279

Merged
merged 1 commit into from
Oct 25, 2023
Merged

update the test waiting for server and client start #1279

merged 1 commit into from
Oct 25, 2023

Conversation

Ceilzcx
Copy link
Contributor

@Ceilzcx Ceilzcx commented Oct 10, 2023 •
edited
Loading

What's changed?

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@Ceilzcx Ceilzcx linked an issue Oct 10, 2023 that may be closed by this pull request
[BUG] <handle todo about remoting await server and client start> #1280
Closed
1 task
@Ceilzcx Ceilzcx requested a review from tomsun28 October 10, 2023 09:53
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Oct 10, 2023
tomsun28
tomsun28 approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@tomsun28 tomsun28 merged commit 3e5f468 into master Oct 25, 2023
2 checks passed
@tomsun28 tomsun28 deleted the fix_netty_test branch October 25, 2023 14:37
ruanliang-hualun pushed a commit that referenced this pull request Oct 26, 2023
@Ceilzcx @ruanliang-hualun
update the test waiting for server and client start (#1279)
0436aef
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@Ceilzcx @tomsun28
update the test waiting for server and client start (#1279)
80e3916
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@Ceilzcx @ruanliang-hualun
update the test waiting for server and client start (#1279)
1c1058a
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@Ceilzcx @ruanliang-hualun
update the test waiting for server and client start (#1279)
8bcb72b
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@Ceilzcx @ruanliang-hualun
update the test waiting for server and client start (#1279)
d6b9aeb
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@Ceilzcx @tomsun28
update the test waiting for server and client start (#1279)
71c0f0f
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Ceilzcx @ruanliang-hualun
update the test waiting for server and client start (#1279)
48c77a7
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Ceilzcx @ruanliang-hualun
update the test waiting for server and client start (#1279)
05ec40e
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Ceilzcx @ruanliang-hualun
update the test waiting for server and client start (#1279)
822b763
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Ceilzcx @ruanliang-hualun
update the test waiting for server and client start (#1279)
f1a7538
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] <handle todo about remoting await server and client start>
2 participants
@Ceilzcx @tomsun28