Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an explicit tag filter #1303

Merged
merged 3 commits into from
Oct 29, 2023
Merged

add an explicit tag filter #1303

merged 3 commits into from
Oct 29, 2023

Conversation

leo-934
Copy link
Contributor

@leo-934 leo-934 commented Oct 29, 2023 •
edited
Loading

What's changed?

add an explicit tag filter.

截屏2023-10-29 22 32 26

This may help users notice the tag filter feature more easily.
from issue #776 which I forgot about half a year ago.

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@leo-934
Copy link
Contributor Author

leo-934 commented Oct 29, 2023

I made this change because I found that I forgot about this issue that was assigned to me half a year ago.
Please approve this if we still need this feature, or close it.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature labels Oct 29, 2023
tomsun28
tomsun28 approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may help users notice the tag filter feature more easily.

hi still needs this feature 👍👍

@tomsun28 tomsun28 added this to the v1.4.2 milestone Oct 29, 2023
@leo-934 leo-934 merged commit 53187f6 into apache:master Oct 29, 2023
2 checks passed
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@leo-934 @tomsun28
add an explicit tag filter (#1303)
3091abd
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@leo-934
add an explicit tag filter (#1303)
cf4f185
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@leo-934
add an explicit tag filter (#1303)
c881809
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@leo-934
add an explicit tag filter (#1303)
86ab3c1
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@leo-934 @tomsun28
add an explicit tag filter (#1303)
8a2f56c
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@leo-934
add an explicit tag filter (#1303)
8ca096f
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@leo-934
add an explicit tag filter (#1303)
29a81ed
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@leo-934
add an explicit tag filter (#1303)
4865011
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@leo-934
add an explicit tag filter (#1303)
6c453f7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers new feature
Projects
None yet
Milestone
v1.4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@leo-934 @tomsun28