Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add time type to support query_time of mysql and mariadb #1364

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Add time type to support query_time of mysql and mariadb #1364

merged 2 commits into from
Nov 30, 2023

Conversation

Clownsw
Copy link
Contributor

@Clownsw Clownsw commented Nov 29, 2023 •
edited
Loading

What's changed?

#1362

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@Clownsw Clownsw changed the title feat(*): Add time type to support query_time of mysql and mariadb Add time type to support query_time of mysql and mariadb Nov 29, 2023
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Nov 29, 2023
@Clownsw Clownsw force-pushed the fix/support-time-type branch 3 times, most recently from d93ea61 to ec8314a Compare November 30, 2023 02:16
@Clownsw
feat(*): Add time type to support query_time of mysql and mariadb
2dd4108 
Signed-off-by: Clownsw <msmliexx1@gmail.com>
@Clownsw
Copy link
Contributor Author

Clownsw commented Nov 30, 2023

@tomsun28 I have fixed eslint and commit gpg issues

tomsun28
tomsun28 approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍LGTM! Many points have been considered.

@tomsun28
Copy link
Contributor

hi, there is still a eslint warning. Suggest run the scripts "lint:fix": "ng lint --fix", in package.json to auto fix it.

/home/runner/work/hertzbeat/hertzbeat/web-app/src/app/routes/alert/alert-setting/alert-setting.component.html
  599:12  error  Insert `⏎`  prettier/prettier
Lint errors found in the listed files.

@tomsun28 tomsun28 linked an issue Nov 30, 2023 that may be closed by this pull request
[BUG] Query time for databases (mysql, mariadb...) should support comparison operations #1362
Closed
1 task
@Clownsw
fix(*): Fix formatting issues with lint:fix
a1e11df 
Signed-off-by: Clownsw <msmliexx1@gmail.com>
@Clownsw
Copy link
Contributor Author

Clownsw commented Nov 30, 2023

hi, there is still a eslint warning. Suggest run the scripts "lint:fix": "ng lint --fix", in package.json to auto fix it.

/home/runner/work/hertzbeat/hertzbeat/web-app/src/app/routes/alert/alert-setting/alert-setting.component.html
  599:12  error  Insert `⏎`  prettier/prettier
Lint errors found in the listed files.

I fixed the commit

@tomsun28
Copy link
Contributor

👍👍 @all-contributors please add @Clownsw for code

@allcontributors allcontributors bot mentioned this pull request Nov 30, 2023
Merged
@allcontributors AllContributors
Copy link
Contributor

@tomsun28

I've put up a pull request to add @Clownsw! 🎉

@tomsun28 tomsun28 merged commit d82761b into apache:master Nov 30, 2023
2 checks passed
@tomsun28 tomsun28 added this to the v1.4.3 milestone Nov 30, 2023
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@Clownsw @tomsun28
add time type to support query_time of mysql and mariadb (#1364)
28a121c 
Signed-off-by: Clownsw <msmliexx1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@Clownsw
add time type to support query_time of mysql and mariadb (#1364)
0c3f9f5 
Signed-off-by: Clownsw <msmliexx1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@Clownsw
add time type to support query_time of mysql and mariadb (#1364)
a0c1bd5 
Signed-off-by: Clownsw <msmliexx1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@Clownsw
add time type to support query_time of mysql and mariadb (#1364)
1c34fee 
Signed-off-by: Clownsw <msmliexx1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@Clownsw @tomsun28
add time type to support query_time of mysql and mariadb (#1364)
b0e639c 
Signed-off-by: Clownsw <msmliexx1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Clownsw
add time type to support query_time of mysql and mariadb (#1364)
58818b8 
Signed-off-by: Clownsw <msmliexx1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Clownsw
add time type to support query_time of mysql and mariadb (#1364)
b8f8a75 
Signed-off-by: Clownsw <msmliexx1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Clownsw
add time type to support query_time of mysql and mariadb (#1364)
0ffc9c4 
Signed-off-by: Clownsw <msmliexx1@gmail.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@Clownsw
add time type to support query_time of mysql and mariadb (#1364)
628cb4c 
Signed-off-by: Clownsw <msmliexx1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
v1.4.3
Development

Successfully merging this pull request may close these issues.

[BUG] Query time for databases (mysql, mariadb...) should support comparison operations
2 participants
@Clownsw @tomsun28