Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code comment and doc, bugfix concurrent exception #1378

Merged
merged 7 commits into from
Dec 4, 2023

Conversation

tomsun28
Copy link
Contributor

@tomsun28 tomsun28 commented Dec 3, 2023

What's changed?

  • update code comment and doc
  • bugfix AssignJobs concurrent modification exception

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Signed-off-by: tomsun28 <tomsun28@outlook.com>
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28 tomsun28 added doc Improvements or additions to documentation bugfix labels Dec 3, 2023
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@zqr10159
Copy link
Member

zqr10159 commented Dec 4, 2023

这是不留所有中文注释吗

@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Does this mean that all Chinese comments are not left?

@tomsun28
Copy link
Contributor Author

tomsun28 commented Dec 4, 2023

这是不留所有中文注释吗

稍微简单的就不留了,复杂的还是留着

@hertzbeat
Copy link
Contributor

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Is this not leaving all Chinese comments?

I won’t keep the simple ones, but keep the complicated ones.

@tomsun28 tomsun28 merged commit 374e0ba into master Dec 4, 2023
2 checks passed
@tomsun28 tomsun28 deleted the bugfix#ConcurrentModificationException branch December 4, 2023 06:05
tomsun28 added a commit that referenced this pull request Jan 16, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Signed-off-by: tomsun28 <tomsun28@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix doc Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants