-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix exception when sending email has special chars #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…转义。 并且没有高并发情况把StringBuffer修改为StringBuilder
tomsun28
added
enhancement
New feature or request
good first pull request
Good for newcomers
labels
Dec 5, 2023
tomsun28
changed the title
fix issue#1355, 和细节的修改
fix exception when sending email has special chars
Dec 5, 2023
1 task
tomsun28
approved these changes
Dec 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM👍👍
tomsun28
pushed a commit
that referenced
this pull request
Jan 16, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: Carpe-Wang <wangcarpe@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Matcher.quoteReplacement(value)
会返回所有的$字符和\字符转义后的字符串,原本的matcher.appendReplacement(buffer, value);
将value字符串直接作为替换文本,蛋value中包含了正则表达式的引用符号(比如$1, $2等表示捕获组的内容),或者有反斜线\(用于转义的),它们将被Matcher类处理为特殊的元字符。这可能导致Illegal group reference错误Checklist