Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add smtp protocol and support smtp monitoring #1407

Merged
merged 4 commits into from
Dec 8, 2023
Merged

add smtp protocol and support smtp monitoring #1407

merged 4 commits into from
Dec 8, 2023

Conversation

ZY945
Copy link
Member

@ZY945 ZY945 commented Dec 8, 2023

What's changed?

Add SMTP protocol to complete response acquisition for banner and hello

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature task labels Dec 8, 2023
@tomsun28 tomsun28 added this to the 1.4.4 milestone Dec 8, 2023
@tomsun28
Copy link
Contributor

tomsun28 commented Dec 8, 2023

👍👍
hi there is a pmd error please fix.

[INFO] --- maven-pmd-plugin:3.12.0:check (validate) @ hertzbeat-collector ---
[INFO] PMD Failure: org.dromara.hertzbeat.collector.collect.smtp.SmtpCollectImpl:105 Rule:CollectionInitShouldAssignCapacityRule Priority:3 【HashMap】初始化时，尽量指定初始值大小.

tomsun28
tomsun28 approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

@ZY945
Copy link
Member Author

ZY945 commented Dec 8, 2023

👍👍 hi there is a pmd error please fix.

[INFO] --- maven-pmd-plugin:3.12.0:check (validate) @ hertzbeat-collector ---
[INFO] PMD Failure: org.dromara.hertzbeat.collector.collect.smtp.SmtpCollectImpl:105 Rule:CollectionInitShouldAssignCapacityRule Priority:3 【HashMap】初始化时，尽量指定初始值大小.

I set the HashMap initialization size to 8

@ZY945
Copy link
Member Author

ZY945 commented Dec 8, 2023

I synchronized with the warehouse in fork and added the following submission. Will this have any negative impact?
Merge remote-tracking branch 'origin/master'

@tomsun28
Copy link
Contributor

tomsun28 commented Dec 8, 2023

I synchronized with the warehouse in fork and added the following submission. Will this have any negative impact? Merge remote-tracking branch 'origin/master'

it's ok, no negative impact.

@tomsun28
Copy link
Contributor

tomsun28 commented Dec 8, 2023

@all-contributors please add @ZY945 for code

@allcontributors allcontributors bot mentioned this pull request Dec 8, 2023
Merged
@allcontributors AllContributors
Copy link
Contributor

@tomsun28

I've put up a pull request to add @ZY945! 🎉

@tomsun28 tomsun28 changed the title Add SMTP protocol add smtp protocol and support smtp monitoring Dec 8, 2023
@tomsun28 tomsun28 merged commit ce63bc8 into apache:master Dec 8, 2023
2 checks passed
@tomsun28 tomsun28 linked an issue Dec 9, 2023 that may be closed by this pull request
[Task] <support monitoring smtp email server metrics> #1395
Open
2 tasks
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@ZY945 @tomsun28
add smtp protocol and support smtp monitoring (#1407)
823f2e0 
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@ZY945
add smtp protocol and support smtp monitoring (#1407)
da62a76 
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@ZY945
add smtp protocol and support smtp monitoring (#1407)
0d632e6 
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@ZY945
add smtp protocol and support smtp monitoring (#1407)
d9bd55f 
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@ZY945 @tomsun28
add smtp protocol and support smtp monitoring (#1407)
368bba5 
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@ZY945
add smtp protocol and support smtp monitoring (#1407)
9653579 
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@ZY945
add smtp protocol and support smtp monitoring (#1407)
6f09261 
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@ZY945
add smtp protocol and support smtp monitoring (#1407)
efc1352 
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@ZY945
add smtp protocol and support smtp monitoring (#1407)
25cf5a3 
Co-authored-by: 东风 <1335799468@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers new feature task
Projects
None yet
Milestone
1.4.4
Development

Successfully merging this pull request may close these issues.

[Task] <support monitoring smtp email server metrics>
2 participants
@ZY945 @tomsun28