Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitoring the availability of websockets through handshake. #1413

Merged
merged 3 commits into from
Dec 10, 2023
Merged

monitoring the availability of websockets through handshake. #1413

merged 3 commits into from
Dec 10, 2023

Conversation

ZY945
Copy link
Member

@ZY945 ZY945 commented Dec 9, 2023

What's changed?

Because websocket will perform a handshake before establishing a connection, we use the socket to obtain the handshake response to determine whether the websocket is available.

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature task labels Dec 9, 2023
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍LGTM!

@tomsun28 tomsun28 merged commit c840aeb into apache:master Dec 10, 2023
2 checks passed
@tomsun28 tomsun28 linked an issue Dec 11, 2023 that may be closed by this pull request
2 tasks
@tomsun28 tomsun28 added this to the 1.4.4 milestone Dec 11, 2023
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers new feature task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] <support monitoring WebSocket metrics>
2 participants