Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support monitoring memcached metrics and add a help doc #1423

Merged
merged 4 commits into from
Dec 15, 2023
Merged

support monitoring memcached metrics and add a help doc #1423

merged 4 commits into from
Dec 15, 2023

Conversation

ZY945
Copy link
Member

@ZY945 ZY945 commented Dec 15, 2023

What's changed?

support monitoring memcached metrics and add a help doc
image

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature task labels Dec 15, 2023
@tomsun28 tomsun28 added this to the 1.4.4 milestone Dec 15, 2023
@tomsun28
Copy link
Contributor

LGTM! 👍👍
and please fix the pmd error

[INFO] --- maven-pmd-plugin:3.12.0:check (validate) @ hertzbeat-collector ---
[INFO] PMD Failure: org.dromara.hertzbeat.collector.collect.memcached.MemcachedCollectImpl:61 Rule:CollectionInitShouldAssignCapacityRule Priority:3 【HashMap】初始化时,尽量指定初始值大小.
[INFO] PMD Failure: org.dromara.hertzbeat.collector.collect.memcached.MemcachedCollectImpl:115 Rule:UndefineMagicConstantRule Priority:3 魔法值【"END"】.
[INFO] PMD Failure: org.dromara.hertzbeat.collector.collect.memcached.MemcachedCollectImpl:129 Rule:UndefineMagicConstantRule Priority:3 魔法值【"END"】.

@ZY945
Copy link
Member Author

ZY945 commented Dec 15, 2023

LGTM! 👍👍 and please fix the pmd error

[INFO] --- maven-pmd-plugin:3.12.0:check (validate) @ hertzbeat-collector ---
[INFO] PMD Failure: org.dromara.hertzbeat.collector.collect.memcached.MemcachedCollectImpl:61 Rule:CollectionInitShouldAssignCapacityRule Priority:3 【HashMap】初始化时,尽量指定初始值大小.
[INFO] PMD Failure: org.dromara.hertzbeat.collector.collect.memcached.MemcachedCollectImpl:115 Rule:UndefineMagicConstantRule Priority:3 魔法值【"END"】.
[INFO] PMD Failure: org.dromara.hertzbeat.collector.collect.memcached.MemcachedCollectImpl:129 Rule:UndefineMagicConstantRule Priority:3 魔法值【"END"】.

Is it possible to modify the magic number through static variables
image

@tomsun28
Copy link
Contributor

Is it possible to modify the magic number through static variables

of course

@tomsun28 tomsun28 merged commit 37d6acc into apache:master Dec 15, 2023
2 checks passed
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
Co-authored-by: 东风 <1335799468@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers new feature task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants