-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support monitoring NebulaGraph metrics and add help doc #1441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsun28
added
enhancement
New feature or request
good first pull request
Good for newcomers
new feature
labels
Dec 23, 2023
tomsun28
approved these changes
Dec 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍LGTM!
tomsun28
reviewed
Dec 23, 2023
Comment on lines
+25
to
+26
# 监控类型的帮助描述信息 | ||
helpLink: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi please add the help and helplink like this:
# The description and help of this monitoring type
# 监控类型的帮助描述信息
help:
zh-CN: Hertzbeat 将调用 HTTP API 接口,查看接口是否可用,并以 ms 为指标单位对其响应时间等指标进行监测。您可以先点击“新增 HTTP API”按钮并进行配置,或在“更多操作”中导入已有配置。
en-US: The platform will invoke an HTTP API endpoint to verify its accessibility and monitor various metrics, including response time, measured in milliseconds (ms). <br>To set up this functionality, you could click the "Add HTTP API" button and proceed with the configuration or import an existing setup through the "More Actions" menu.
zh-TW: Hertzbeat將調用HTTP API介面,查看介面是否可用,並以ms為名額組織對其回應時間等名額進行監測。 您可以先點擊“新增HTTP API”按鈕並進行配寘,或在“更多操作”中導入已有配寘。
helpLink:
zh-CN: https://hertzbeat.com/zh-cn/docs/help/api
en-US: https://hertzbeat.com/docs/help/api
tomsun28
pushed a commit
that referenced
this pull request
Jan 16, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: 东风 <1335799468@qq.com>
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: 东风 <1335799468@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Checklist
Add or update API