Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix delete monitor error after monitor canceled #1451

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

ZhangZixuan1994
Copy link
Contributor

取消监控cancelManageMonitors方法:删除设置jobId为空。否则取消监控后,无法删除该监控项。
jobId保留可以等待下次开启监控时复用该jobId,不影响其他功能。

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers bugfix labels Dec 27, 2023
@tomsun28 tomsun28 added this to the 1.4.4 milestone Dec 27, 2023
@tomsun28 tomsun28 changed the title fix 取消监控后,删除监控的bug bugfix delete monitor error after monitor canceled Dec 27, 2023
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

@tomsun28
Copy link
Contributor

@all-contributors please add @ZhangZixuan1994 for code

@tomsun28 tomsun28 merged commit 0ce9e08 into apache:master Dec 27, 2023
2 checks passed
Copy link
Contributor

@tomsun28

I've put up a pull request to add @ZhangZixuan1994! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants