-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] support snmp v3 monitoring protocol #1469
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsun28
added
enhancement
New feature or request
good first pull request
Good for newcomers
new feature
labels
Jan 3, 2024
tomsun28
approved these changes
Jan 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!👍👍
tomsun28
changed the title
Feature/snmp v3
[feature] support snmp v3 monitoring protocol
Jan 3, 2024
tomsun28
reviewed
Jan 3, 2024
Comment on lines
+396
to
+400
username: ^_^username^_^ | ||
authPassphrase: ^_^authPassphrase^_^ | ||
privPassphrase: ^_^privPassphrase^_^ | ||
privPasswordEncryption: ^_^privPasswordEncryption^_^ | ||
authPasswordEncryption: ^_^authPasswordEncryption^_^ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
field contextName
seem not used in snmp protocol config
1 task
tomsun28
pushed a commit
that referenced
this pull request
Jan 16, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 9, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 10, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
tomsun28
pushed a commit
that referenced
this pull request
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Changed SnmpCollectImpl and related yml configuration files
snmp v3 monitoring protocol completed
Checklist
Add or update API