Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] support snmp v3 monitoring protocol #1469

Merged
merged 8 commits into from
Jan 4, 2024
Merged

Conversation

TJxiaobao
Copy link
Contributor

@TJxiaobao TJxiaobao commented Jan 3, 2024

What's changed?

Changed SnmpCollectImpl and related yml configuration files

snmp v3 monitoring protocol completed

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature labels Jan 3, 2024
@tomsun28 tomsun28 linked an issue Jan 3, 2024 that may be closed by this pull request
@tomsun28 tomsun28 added this to the 1.4.4 milestone Jan 3, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

@tomsun28 tomsun28 changed the title Feature/snmp v3 [feature] support snmp v3 monitoring protocol Jan 3, 2024
Comment on lines +396 to +400
username: ^_^username^_^
authPassphrase: ^_^authPassphrase^_^
privPassphrase: ^_^privPassphrase^_^
privPasswordEncryption: ^_^privPasswordEncryption^_^
authPasswordEncryption: ^_^authPasswordEncryption^_^
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

field contextName seem not used in snmp protocol config

@tomsun28 tomsun28 merged commit 47f8435 into master Jan 4, 2024
2 checks passed
@tomsun28 tomsun28 deleted the feature/snmp_v3 branch January 4, 2024 01:27
@tomsun28 tomsun28 linked an issue Jan 12, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first pull request Good for newcomers new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] <title>Huawei switches need software to support SNMP v3 snmp V3 version not available
2 participants