Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: snmpv3 contextName bug #1473

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fixed: snmpv3 contextName bug #1473

merged 2 commits into from
Jan 4, 2024

Conversation

TJxiaobao
Copy link
Contributor

What's changed?

Added contextname judgment method and removed the default value of contextName field

fixed: snmpv3 contextName bug

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

tomsun28
tomsun28 approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers bugfix labels Jan 4, 2024
@tomsun28
update doc
777423d 
Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28 tomsun28 merged commit 8bd5f5a into master Jan 4, 2024
2 checks passed
@tomsun28 tomsun28 deleted the fix_snmpv3_contextName branch January 4, 2024 14:02
tomsun28 pushed a commit that referenced this pull request Jan 16, 2024
@TJxiaobao @tomsun28
fixed: snmpv3 contextName bug (#1473)
b24afb7
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@TJxiaobao
fixed: snmpv3 contextName bug (#1473)
735cf81
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@TJxiaobao
fixed: snmpv3 contextName bug (#1473)
4f95ebf
tomsun28 pushed a commit that referenced this pull request Mar 9, 2024
@TJxiaobao @tomsun28
fixed: snmpv3 contextName bug (#1473)
0706dc6
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@TJxiaobao
fixed: snmpv3 contextName bug (#1473)
ac0c4d1
tomsun28 pushed a commit that referenced this pull request Mar 10, 2024
@TJxiaobao @tomsun28
fixed: snmpv3 contextName bug (#1473)
1d86824
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@TJxiaobao
fixed: snmpv3 contextName bug (#1473)
109ec9f
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@TJxiaobao
fixed: snmpv3 contextName bug (#1473)
720ddac
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@TJxiaobao
fixed: snmpv3 contextName bug (#1473)
fa9dc70
tomsun28 pushed a commit that referenced this pull request Mar 11, 2024
@TJxiaobao
fixed: snmpv3 contextName bug (#1473)
e5e56be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TJxiaobao @tomsun28