Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix npt of webhook notify #1474

Merged
merged 22 commits into from
Jan 6, 2024
Merged

Fix npt of webhook notify #1474

merged 22 commits into from
Jan 6, 2024

Conversation

Calvin979
Copy link
Contributor

@Calvin979 Calvin979 commented Jan 6, 2024

What's changed?

See also: #1444
我没有复现这个issue反馈的问题,所以在webhook的模板渲染那里加了判空

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers bugfix labels Jan 6, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

@tomsun28 tomsun28 merged commit d195bf1 into apache:master Jan 6, 2024
2 checks passed
tomsun28 added a commit that referenced this pull request Jan 16, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
Co-authored-by: zhengqiwei <zhengqiwei@wxchina.com>
Co-authored-by: tomsun28 <tomsun28@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants