Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: search monitors error when pageable #1470 #1491

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

avvCode
Copy link
Contributor

@avvCode avvCode commented Jan 15, 2024

What's changed?

I've added a new function, changeMonitorTable, so that it can be paginated after search and still carry parameters.

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@avvCode avvCode changed the title git commit -m 'bugfix: search monitors error when pageable #1470' bugfix: search monitors error when pageable #1470 Jan 15, 2024
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers bugfix labels Jan 16, 2024
@tomsun28 tomsun28 added this to the 1.4.5 milestone Jan 16, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍👍

@tomsun28 tomsun28 linked an issue Jan 16, 2024 that may be closed by this pull request
1 task
@tomsun28
Copy link
Contributor

@all-contributors please add @avvCode for code

Copy link
Contributor

@tomsun28

I've put up a pull request to add @avvCode! 🎉

@tomsun28 tomsun28 merged commit 08c9208 into apache:master Jan 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] <search monitors error when pageable>
2 participants