Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alert notice add monitor host #1515

Merged
merged 3 commits into from
Jan 26, 2024
Merged

alert notice add monitor host #1515

merged 3 commits into from
Jan 26, 2024

Conversation

yqxxgh
Copy link
Contributor

@yqxxgh yqxxgh commented Jan 25, 2024

What's changed?

lert notice add monitor host

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Jan 25, 2024
@tomsun28 tomsun28 added this to the 1.4.5 milestone Jan 25, 2024
tomsun28
tomsun28 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

@tomsun28 tomsun28 linked an issue Jan 26, 2024 that may be closed by this pull request
[BUG] <Does monitorHost in the message notification template refer to the resource IP> #1508
Closed
1 task
@tomsun28 tomsun28 merged commit ab19f61 into master Jan 26, 2024
2 checks passed
@tomsun28 tomsun28 deleted the alert-notify-host branch January 26, 2024 03:34
@tomsun28 tomsun28 mentioned this pull request Feb 6, 2024
Open
1 task
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@yqxxgh @tomsun28
alert notice add monitor host (#1515)
a1c971b 
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@yqxxgh @tomsun28
alert notice add monitor host (#1515)
d371077 
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 9, 2024
@yqxxgh @tomsun28
alert notice add monitor host (#1515)
8a80e05 
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
@yqxxgh @tomsun28
alert notice add monitor host (#1515)
1ace201 
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 10, 2024
@yqxxgh @tomsun28
alert notice add monitor host (#1515)
2110f75 
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@yqxxgh @tomsun28
alert notice add monitor host (#1515)
83518bb 
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@yqxxgh @tomsun28
alert notice add monitor host (#1515)
f12473b 
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@yqxxgh @tomsun28
alert notice add monitor host (#1515)
ba71a4c 
Co-authored-by: tomsun28 <tomsun28@outlook.com>
tomsun28 added a commit that referenced this pull request Mar 11, 2024
@yqxxgh @tomsun28
alert notice add monitor host (#1515)
b91e58c 
Co-authored-by: tomsun28 <tomsun28@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

@gcdd1993 gcdd1993 Awaiting requested review from gcdd1993

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.

[BUG] <Does monitorHost in the message notification template refer to the resource IP>
2 participants
@yqxxgh @tomsun28