Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support monitor metrics name i18n: rocketmq #1663

Merged
merged 2 commits into from
Mar 18, 2024
Merged

support monitor metrics name i18n: rocketmq #1663

merged 2 commits into from
Mar 18, 2024

Conversation

ZY945
Copy link
Member

@ZY945 ZY945 commented Mar 17, 2024

What's changed?

support monitor metrics name i18n: rocketmq

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@ZY945 ZY945 requested a review from tomsun28 March 17, 2024 14:59
@tomsun28 tomsun28 added doc Improvements or additions to documentation good first pull request Good for newcomers labels Mar 18, 2024
TJxiaobao
TJxiaobao approved these changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@TJxiaobao TJxiaobao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@ZY945 ZY945 merged commit 04bece2 into master Mar 18, 2024
2 checks passed
@ZY945 ZY945 deleted the app-rocketmq-metrics-internation branch March 18, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TJxiaobao TJxiaobao TJxiaobao approved these changes

@tomsun28 tomsun28 Awaiting requested review from tomsun28

@a-little-fool a-little-fool Awaiting requested review from a-little-fool

Assignees
No one assigned
Labels
doc Improvements or additions to documentation good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZY945 @TJxiaobao @tomsun28