Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] add storm monitor #1673

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[feature] add storm monitor #1673

merged 1 commit into from
Mar 21, 2024

Conversation

starmilkxin
Copy link
Contributor

@starmilkxin starmilkxin commented Mar 21, 2024 •
edited
Loading

What's changed?

#992
Added Storm monitoring. Obtaining cluster summary information via HTTP request.

17edabd9f101de7291f91bdd2e31382 652aee92f4376fe7ee35d80a103703a

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature labels Mar 21, 2024
@tomsun28 tomsun28 added this to the 1.5.1 milestone Mar 21, 2024
@tomsun28 tomsun28 linked an issue Mar 21, 2024 that may be closed by this pull request
[Task] <support monitoring apache storm metrics> #992
Closed
2 tasks
tomsun28
tomsun28 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍 LGTM！ We can also add authentication configuration(username password or token) later to support access to the securely protected strom api.

@tomsun28 tomsun28 merged commit 6500a30 into apache:master Mar 21, 2024
2 checks passed
@starmilkxin
Copy link
Contributor Author

👍👍 LGTM！ We can also add authentication configuration(username password or token) later to support access to the securely protected strom api.

Sure, I'll take some time to look into it when I'm free.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers new feature
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

[Task] <support monitoring apache storm metrics>
2 participants
@starmilkxin @tomsun28