Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] fixed the issue in http_sd where services were incorrectly reported as available when they were actually unavailable #1678

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

starmilkxin
Copy link
Contributor

fixed the issue in http_sd where services were incorrectly reported as available when they were actually unavailable

What's changed?

When the service is actually unavailable, it still indicates as available:
f547ef6c5008868a28f09bb5837de04
1afef094a81b437360201487d5d40ea

After fixing the bug:
9b2b72812bc18b3bbe44b924b7136bd
1df35d12fec3292ad0da17889a93fd9

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@zqr10159 zqr10159 merged commit bacc5a6 into apache:master Mar 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants