Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mysql-oracle dependency jar from release package lib #1680

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

tomsun28
Copy link
Contributor

What's changed?

remove mysql-oracle dependency jar from release package lib
if user want to use it, please download it yourself and put it in the lib directory for use.
mysql-connector-java ojdbc8 orai18n

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Signed-off-by: tomsun28 <tomsun28@outlook.com>
@tomsun28 tomsun28 added this to the 1.5.1 milestone Mar 22, 2024
@tomsun28 tomsun28 requested a review from zqr10159 March 22, 2024 08:45
Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

groupId mysql is obsolete and no longer maintained, it is better to use com.mysql.mysql-connector-j

Copy link
Contributor

@wang1027-wqh wang1027-wqh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Release package removes mysql-oracle dependency

@zqr10159 zqr10159 merged commit a53c748 into master Mar 22, 2024
2 checks passed
@tomsun28
Copy link
Contributor Author

groupId mysql is obsolete and no longer maintained, it is better to use com.mysql.mysql-connector-j

OK,we can replace it later.

@zqr10159 zqr10159 deleted the remove-unlicense-dependen branch September 23, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants