-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support config common aes secret #1683
Conversation
Signed-off-by: tomsun28 <tomsun28@outlook.com>
todo, consider not init cipher in AesUtil every time and test performance |
Does this mean using singleton (not every initialization)? |
yes, and we should consider the situation that not |
👍okay. also need in encode method. Suggest we add unit test to test it and put it anothor new pr. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's changed?
support config common aes secret
Checklist
Add or update API