Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix]fix the issue of add redis cluster node test error report(#1601) #1684

Merged
merged 4 commits into from
Mar 26, 2024
Merged

[bugfix]fix the issue of add redis cluster node test error report(#1601) #1684

merged 4 commits into from
Mar 26, 2024

Conversation

LiuTianyou
Copy link
Contributor

What's changed?

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added this to the 1.5.1 milestone Mar 25, 2024
tomsun28
tomsun28 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomsun28
Copy link
Contributor

@all-contributors please add @LiuTianyou for code

@allcontributors allcontributors bot mentioned this pull request Mar 25, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@tomsun28

I've put up a pull request to add @LiuTianyou! 🎉

@tomsun28 tomsun28 linked an issue Mar 25, 2024 that may be closed by this pull request
Add redis cluster node test error report #1601
Closed
@tomsun28 tomsun28 merged commit c18becf into apache:master Mar 26, 2024
2 checks passed
@LiuTianyou LiuTianyou deleted the fix-1601 branch April 17, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
bugfix good first pull request Good for newcomers
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

Add redis cluster node test error report
2 participants
@LiuTianyou @tomsun28