Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mongodb monitoring support custom connection timeout param #1697

Merged
merged 2 commits into from
Mar 29, 2024
Merged

mongodb monitoring support custom connection timeout param #1697

merged 2 commits into from
Mar 29, 2024

Conversation

ZY945
Copy link
Member

@ZY945 ZY945 commented Mar 29, 2024

What's changed?

mongodb monitoring support custom connection timeout param
https://www.mongodb.com/docs/drivers/java/sync/current/fundamentals/connection/mongoclientsettings/#mongoclient-settings

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@ZY945 ZY945 linked an issue Mar 29, 2024 that may be closed by this pull request
[Task] <mongodb monitoring support custom connection timeout param> #1487
Closed
1 task
@ZY945 ZY945 requested a review from tomsun28 March 29, 2024 07:14
@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Mar 29, 2024
@tomsun28 tomsun28 added this to the 1.5.1 milestone Mar 29, 2024
tomsun28
tomsun28 approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍👍

@tomsun28 tomsun28 merged commit 5db2674 into master Mar 29, 2024
2 checks passed
@ZY945 ZY945 deleted the mongodb branch March 29, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.

[Task] <mongodb monitoring support custom connection timeout param>
2 participants
@ZY945 @tomsun28