Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update manager and collector logback config(#1704) #1723

Merged
merged 4 commits into from
Apr 10, 2024
Merged

update manager and collector logback config(#1704) #1723

merged 4 commits into from
Apr 10, 2024

Conversation

handy-git
Copy link
Contributor

@handy-git handy-git commented Apr 9, 2024 •
edited
Loading

What's changed?

Checklist

  • I hereby agree to the terms of the HertzBeat CLA
  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

tomsun28
tomsun28 reviewed Apr 9, 2024
View reviewed changes
collector/src/main/resources/logback-spring.xml Outdated
@@ -94,7 +94,7 @@
<!-- 生产环境配置 -->
<springProfile name="prod">
<root level="INFO">
<appender-ref ref="ConsoleAppender"/>
<!--<appender-ref ref="ConsoleAppender"/>-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!--<appender-ref ref="ConsoleAppender"/>-->

tomsun28
tomsun28 reviewed Apr 9, 2024
View reviewed changes
manager/src/main/resources/logback-spring.xml Outdated
@@ -94,7 +94,7 @@
<!-- 生产环境配置 -->
<springProfile name="prod">
<root level="INFO">
<appender-ref ref="ConsoleAppender"/>
<!--<appender-ref ref="ConsoleAppender"/>-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!--<appender-ref ref="ConsoleAppender"/>-->

tomsun28
tomsun28 reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 suggest remove ConsoleAppender in collector <springProfile name="cluster">

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers labels Apr 9, 2024
@handy-git
Copy link
Contributor Author

👍 suggest remove ConsoleAppender in collector <springProfile name="cluster">

I've taken care of it.

@tomsun28 tomsun28 linked an issue Apr 10, 2024 that may be closed by this pull request
[Task] <update logback config> #1704
Closed
1 task
@tomsun28
Copy link
Contributor

👍👍 hi, one more thing. Can you help us update the chinese desc to english desc in these file. eg: <!--日志保留时长-->

@handy-git
Copy link
Contributor Author

👍 suggest remove ConsoleAppender in collector <springProfile name="cluster">

ok

@tomsun28 tomsun28 merged commit d7f9093 into apache:master Apr 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] <update logback config>
2 participants
@handy-git @tomsun28