Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve] run hertzbeat in docker compose support dependen service condition #1748

Merged
merged 2 commits into from
Apr 15, 2024
Merged

[Improve] run hertzbeat in docker compose support dependen service condition #1748

merged 2 commits into from
Apr 15, 2024

Conversation

gjjjj0101
Copy link
Contributor

What's changed?

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers new feature labels Apr 15, 2024
@tomsun28 tomsun28 linked an issue Apr 15, 2024 that may be closed by this pull request
[Task] <run hertzbeat in docker compose support dependen service condition> #1675
Closed
2 tasks
@tomsun28 tomsun28 requested a review from zqr10159 April 15, 2024 08:25
zqr10159
zqr10159 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@zqr10159 zqr10159 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@zqr10159 zqr10159 merged commit 778666c into apache:master Apr 15, 2024
@gjjjj0101 gjjjj0101 deleted the enhance_docker-compose-denpends_on branch April 15, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zqr10159 zqr10159 zqr10159 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request good first pull request Good for newcomers new feature
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] <run hertzbeat in docker compose support dependen service condition>
3 participants
@gjjjj0101 @zqr10159 @tomsun28