Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] method improvement rationale #1757

Merged
merged 5 commits into from
Apr 17, 2024
Merged

[refactor] method improvement rationale #1757

merged 5 commits into from
Apr 17, 2024

Conversation

dukbong
Copy link
Contributor

@dukbong dukbong commented Apr 16, 2024

What's changed?

The improved method below utilizes the StringUtils.isAnyEmpty() method from the Apache Commons Lang library to enhance readability and maintainability. This change improves code conciseness and clarity while reducing repetitive null and empty string checks. Moreover, using these utility methods makes the code's intent clearer and decreases the likelihood of errors.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added enhancement New feature or request good first pull request Good for newcomers refactor labels Apr 16, 2024
@tomsun28 tomsun28 changed the title RECOMMEND : Method Improvement Rationale [refactor] method improvement rationale Apr 16, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

@tomsun28 tomsun28 requested a review from TJxiaobao April 17, 2024 08:07
Copy link
Contributor

@TJxiaobao TJxiaobao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍!!!

@TJxiaobao TJxiaobao merged commit 7fe6d2d into apache:master Apr 17, 2024
3 checks passed
@dukbong
Copy link
Contributor Author

dukbong commented Apr 17, 2024

Thanks!! @TJxiaobao !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants