Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : ingress tls inoperative #1760

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix : ingress tls inoperative #1760

merged 1 commit into from
Apr 17, 2024

Conversation

PeixyJ
Copy link
Contributor

@PeixyJ PeixyJ commented Apr 17, 2024

What's changed?

  1. repair default value.yaml ingress tls secretName path error.
  2. add ingress class name property

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

none

@PeixyJ
fix : ingress tls inoperative
b413eec 
1. repair default value.yaml ingress tls secretName path error.
2. add ingress class name property
@PeixyJ PeixyJ mentioned this pull request Apr 17, 2024
Merged
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Apr 17, 2024
tomsun28
tomsun28 approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👍

@tomsun28 tomsun28 merged commit ea7fd2b into apache:master Apr 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
good first pull request Good for newcomers helm kubernetes script
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PeixyJ @tomsun28