Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature]Hertzbeat custom plugin. #1973

Merged
merged 25 commits into from
May 13, 2024
Merged

[feature]Hertzbeat custom plugin. #1973

merged 25 commits into from
May 13, 2024

Conversation

zqr10159
Copy link
Member

What's changed?

Currently Hertzbeat in use , mainly rely on the alert module to notify the user , and then the user to take a number of measures such as sending a request , the execution of sql , the execution of shell scripts , etc. , but can only be manually or webhook to receive the alert information for automated processing , this pr add a plugin module , the module has an interface Plugin, the user can implement this interface execute method to receive Alert as a parameter for customized operations. After writing the code, users only need to package the plugin module, copy it to the /ext-lib folder in the installation directory, restart the main hertzbeat program, you can realize the custom function of executing the alert, without having to re-package and deploy the whole program.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@zqr10159 zqr10159 requested a review from tomsun28 May 13, 2024 02:14
github-actions[bot]

This comment was marked as resolved.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 13, 2024
Copy link
Member

@crossoverJie crossoverJie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gread job, I left a few comments so we can discuss it.

@github-actions github-actions bot added the infra label May 13, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍LGTM

@crossoverJie
Copy link
Member

Gread job, LGTM.

Some documentation will need to be added later.

@zqr10159
Copy link
Member Author

Gread job, LGTM.

Some documentation will need to be added later.

I will

@zqr10159 zqr10159 merged commit de0de1c into master May 13, 2024
3 checks passed
@zqr10159 zqr10159 deleted the udf branch May 13, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants