Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] designated personnel send message #2038

Merged
merged 7 commits into from
Jun 13, 2024
Merged

[feature] designated personnel send message #2038

merged 7 commits into from
Jun 13, 2024

Conversation

zhangshenghang
Copy link
Member

What's changed?

#2016

  1. Added verification of the format of the enterprise WeChat warning mobile phone number
  2. Added Feishu@ function
  3. Added DingTalk@ function
  4. Optimized some codes

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label May 28, 2024
@tomsun28 tomsun28 added this to the 1.6.1 milestone May 28, 2024
@tomsun28
Copy link
Contributor

LGTM!👍 please wait for days, we will merge after new release.

tomsun28
tomsun28 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@tomsun28 tomsun28 merged commit af1f59e into apache:master Jun 13, 2024
4 checks passed
@zhangshenghang zhangshenghang deleted the feature-designated-personnel-send-message branch September 3, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend good first pull request Good for newcomers webapp
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.
2 participants
@zhangshenghang @tomsun28