Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add column Version and Public Ip on Collector page #2072

Merged
merged 3 commits into from
Jun 16, 2024

Conversation

Calvin979
Copy link
Contributor

@Calvin979 Calvin979 commented Jun 8, 2024

What's changed?

Relate issue: #1549
image

Seems it is difficult to get public ip in Java directly, therefore I add a configuration public-ip-env for getting public ip from environment.
image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28
Copy link
Contributor

tomsun28 commented Jun 8, 2024

hi thanks lgtm !👍👍 Suggest we can combine the ip and public ip into one ip.
When user custom config the collector ip like below, we use the custom ip, else we use the ip we detect by program like before.

collector:
  info: 
     version: 1.5.0
     ip: 38.44.3.5

@Calvin979
Copy link
Contributor Author

hi thanks lgtm !👍👍 Suggest we can combine the ip and public ip into one ip. When user custom config the collector ip like below, we use the custom ip, else we use the ip we detect by program like before.

collector:
  info: 
     version: 1.5.0
     ip: 38.44.3.5

Code has been updated by your suggestion.

@tomsun28 tomsun28 added this to the 1.6.1 milestone Jun 9, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks.

@tomsun28 tomsun28 merged commit b7217b5 into apache:master Jun 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants