Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[license] update license document for jutf7 #2082

Merged
merged 3 commits into from
Jun 17, 2024
Merged

[license] update license document for jutf7 #2082

merged 3 commits into from
Jun 17, 2024

Conversation

Calvin979
Copy link
Contributor

@Calvin979 Calvin979 commented Jun 15, 2024 •
edited
Loading

What's changed?

link issue: #2081
link pr: #2059

Where does jutf7 license info come from?
https://jutf7.sourceforge.net/license.html

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label Jun 15, 2024
@tomsun28 tomsun28 linked an issue Jun 15, 2024 that may be closed by this pull request
[Task] <Add and update license documents for newly added third-party dependency packages> #2081
Closed
tomsun28
tomsun28 approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! This can be used as a good sample pr for adding a thrid license.

@tomsun28 tomsun28 changed the title docs: update license document for jutf7 [license] update license document for jutf7 Jun 16, 2024
@tomsun28 tomsun28 merged commit 26b982a into apache:master Jun 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
good first pull request Good for newcomers license
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] <Add and update license documents for newly added third-party dependency packages>
2 participants
@Calvin979 @tomsun28