Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: greptimedb can't work with version >= 0.5 #2095

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

killme2008
Copy link
Contributor

@killme2008 killme2008 commented Jun 18, 2024

What's changed?

Close #1754

Fixed GreptimeDbDataStorage can't work with GreptimeDB >= 0.5:

  • Rename GrepTimeDbDataStorage to GreptimeDbDataStorage.
  • Change queries from deprecated gRPC client to JDBC.
  • Upgrade GreptimeDB client version to 0.7.3
  • Refactor some code

Test with MySQL monitor:

Screenshot 2024-06-18 at 14 06 10

Not relevant to this PR, but I found that Prometheus Collector is not working, it always adds a prefix _ to app when saving data but not in queries.

image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@github-actions github-actions bot added the doc Improvements or additions to documentation label Jun 18, 2024
@zqr10159
Copy link
Member

Thank you very much for your help.

@tomsun28 tomsun28 added the good first pull request Good for newcomers label Jun 19, 2024
@tomsun28 tomsun28 added this to the 1.6.1 milestone Jun 19, 2024
@tomsun28
Copy link
Contributor

Thanks for contribution. local test ok. 👍👍

Not relevant to this PR, but I found that Prometheus Collector is not working, it always adds a prefix _ to app when saving data but not in queries.

I found it is other storage common bug due victoriaMetrics adaptation, we will fix it later.

Btw, may i ask how is the protocol compatibility of greptime's prometheus api? We want to try greptime prometheus api in the future, just like victoriaMetrics as a recommond storage. Because we are designing new data stru and integrating the grafana page capabilities, . thanks.

@tomsun28 tomsun28 requested a review from zqr10159 June 19, 2024 09:44
@zqr10159 zqr10159 merged commit 1bac42b into apache:master Jun 19, 2024
4 checks passed
@killme2008 killme2008 deleted the fix/greptimedb branch June 19, 2024 16:25
@killme2008
Copy link
Contributor Author

killme2008 commented Jun 19, 2024

Thanks for contribution. local test ok. 👍👍

Not relevant to this PR, but I found that Prometheus Collector is not working, it always adds a prefix _ to app when saving data but not in queries.

I found it is other storage common bug due victoriaMetrics adaptation, we will fix it later.

Btw, may i ask how is the protocol compatibility of greptime's prometheus api? We want to try greptime prometheus api in the future, just like victoriaMetrics as a recommond storage. Because we are designing new data stru and integrating the grafana page capabilities, . thanks.

Sure, GreptimeDB totally supports Prometheus remote storage(and compatible with vmagent) protocols, please read the doc

https://docs.greptime.com/user-guide/write-data/prometheus#a-note-for-victoriametrics-remote-write

And if you want to use PromQL query API, it's supported too

https://docs.greptime.com/user-guide/query-data/promql#greptimedb-s-http-api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend doc Improvements or additions to documentation good first pull request Good for newcomers
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] 启用 GreptimeDB 后启动失败
3 participants