Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the border-radius values of the all components. #2140

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

kerwin612
Copy link
Member

What's changed?

662e6f24c7e0a0e3fcd9156c2fc30b4
As shown in the screenshot, the system is filled with various rounded corners of different ratios. Now, Unify the rounded corners into two values: the rounded corners of functional components will be unified to 4, and the rounded corners of container components will be unified to 8. From now on, there will be only two kinds of rounded corner values in the system, and there will be no more inconsistencies.

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@zqr10159 zqr10159 merged commit ec1c41c into apache:master Jun 25, 2024
3 checks passed
kerwin612 added a commit to kerwin612/hertzbeat that referenced this pull request Jun 26, 2024
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Jun 26, 2024
@tomsun28 tomsun28 added this to the 1.6.1 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants