Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve]WeCom app supports sending to specific users, departments, tags #2220

Merged
merged 24 commits into from
Jul 5, 2024

Conversation

zqr10159
Copy link
Member

@zqr10159 zqr10159 commented Jul 5, 2024

What's changed?

[improve]WeCom app supports sending to specific users, departments, tags

  • Rename WeChatApp to WeComApp in alert notice components and i18n files.
  • Update receiver types and notice types to reflect the name change.
  • Add new fields for WeComApp in NoticeReceiver class and update handler implementations.
  • Modify tests to comply with the updated WeComApp functionality.
    62aa75ed880752f3fc6ec5d9407b1122
    d35da5b0338dc96da0c8ad78447b1d07

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

…ions

- Rename `WeChatApp` to `WeComApp` in alert notice components and i18n files.
- Update receiver types and notice types to reflect the name change.
- Add new fields for `WeComApp` in `NoticeReceiver` class and update handler implementations.
- Modify tests to comply with the updated `WeComApp` functionality.
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 19.30%. Comparing base (4149a02) to head (3658f4c).

Files Patch % Lines
...t/alerter/impl/WeComAppAlertNotifyHandlerImpl.java 0.00% 17 Missing ⚠️
...ertzbeat/common/entity/manager/NoticeReceiver.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2220      +/-   ##
============================================
- Coverage     19.32%   19.30%   -0.02%     
  Complexity     1042     1042              
============================================
  Files           399      399              
  Lines         16968    16983      +15     
  Branches       2250     2257       +7     
============================================
  Hits           3279     3279              
- Misses        13332    13347      +15     
  Partials        357      357              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomsun28 tomsun28 added this to the 1.6.1 milestone Jul 5, 2024
@tomsun28 tomsun28 added the good first pull request Good for newcomers label Jul 5, 2024
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomsun28 tomsun28 merged commit c3faea0 into master Jul 5, 2024
4 checks passed
@zqr10159 zqr10159 deleted the Enterprise-WeChat-application branch July 5, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[Task] Enterprise WeChat application supports custom notifications for user group
3 participants