-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] Support custom refresh intervals for each group of metrics #2252
Conversation
hi, thanks for contributions. 👍 The one monitor mapping one collect job -> many collect jobs is a big change, we need time to think and design carefully. Previously, I thought the modification direction was in the collector scheduling part, splitting the scheduling time of multiple metrics tasks in a job corresponding to a monitoring. These two directions need to be carefully considered. |
That makes sense, I'll try to implement the second approach. |
What's changed?
close #2188
Support custom refresh intervals for each group of metrics. The specific implementation is as follows:
Within a
monitor
,metrics
withdifferent refresh intervals
are divided intodifferent jobs
. If a group's metrics do not have a custom refresh interval set, the default refresh interval specified during the monitor's creation will be used.Implementation result:
![image](https://private-user-images.githubusercontent.com/61108539/346781197-a6117ed9-183d-46a7-9eb4-dd002dd58ccb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NDgzNDAsIm5iZiI6MTczOTY0ODA0MCwicGF0aCI6Ii82MTEwODUzOS8zNDY3ODExOTctYTYxMTdlZDktMTgzZC00NmE3LTllYjQtZGQwMDJkZDU4Y2NiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDE5MzQwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQxODFiMTM2ODkzMWExN2E5NDU5MTQ4ODZjODE2YTIzNDU3ZTRkODQwZDA3ZDk2MzRiNGM4NmZlNjI3Zjc2YjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.BNt6kil2tlZaBsLAK136twwX_QjXTX3DRJ4fH9_tDBI)
![image](https://private-user-images.githubusercontent.com/61108539/346781230-10f13a2c-9dbe-46f1-9f54-20e827ab9513.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NDgzNDAsIm5iZiI6MTczOTY0ODA0MCwicGF0aCI6Ii82MTEwODUzOS8zNDY3ODEyMzAtMTBmMTNhMmMtOWRiZS00NmYxLTlmNTQtMjBlODI3YWI5NTEzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDE5MzQwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ5MmM0Mjc0MWM5NGQ3ZmIwMmZlNTE5NDExNTcyM2MyNTkzYzA1OWYwNWRkOTE1NTEyYTc1MGUxZjU2NjIwY2MmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.YTkZ60_cBPskK60TqlDKxKA_v3iWIgc3knc6Ey4Ki3s)
![image](https://private-user-images.githubusercontent.com/61108539/346781422-eac1a6ee-37d8-47c6-a2d5-4661c7fbfee1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NDgzNDAsIm5iZiI6MTczOTY0ODA0MCwicGF0aCI6Ii82MTEwODUzOS8zNDY3ODE0MjItZWFjMWE2ZWUtMzdkOC00N2M2LWEyZDUtNDY2MWM3ZmJmZWUxLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTUlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE1VDE5MzQwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdkMzBjZjgxNzFmODQzMWYzNjI3NzJjZGQzNDFiMzlmOWI3ZDAwZjNmNWEyMGMyZjlmNDYyNWE0OGQyYTA3NWEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.aHc1JjNN38ERQNX2dhSrcViA4I4sKbmVHJZ1wtk0Hb0)
Checklist