Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Support custom refresh intervals for each group of metrics #2271

Closed
wants to merge 9 commits into from

Conversation

zuobiao-zhou
Copy link
Member

@zuobiao-zhou zuobiao-zhou commented Jul 11, 2024

What's changed?

close #2188

Support custom refresh intervals for each group of metrics. The specific implementation is as follows:

  1. Construct a cycle of job refresh interval list based on the refresh intervals of each metric.
  2. When the job dispatches, select metrics that are due for refresh to form priorMetrics.

Implementation result:
image
image
image

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@github-actions github-actions bot added doc Improvements or additions to documentation collector backend labels Jul 11, 2024
@tomsun28 tomsun28 self-requested a review July 12, 2024 00:51
@tomsun28 tomsun28 added this to the 1.6.1 milestone Jul 15, 2024
@tomsun28
Copy link
Contributor

hi sorry for slow response. The idea of ​​implementing is great 👍👍

There is a strange bug here when I test.

I set intervals 30 or 60s when adds port monitoring, the collect interval time work success.

iShot_2024-07-17_09 21 00 iShot_2024-07-17_09 21 43 iShot_2024-07-17_09 21 18

But when i add ubuntu monitoring, config the intervals 60s, the real collect interval time is 2*60s. Seem it is caused by multiple metrics collection and scheduling under ubuntu, and port only has one metric.

iShot_2024-07-17_09 26 45 iShot_2024-07-17_09 26 55 iShot_2024-07-17_09 27 07

@zuobiao-zhou
Copy link
Member Author

Hi @tomsun28, thanks for your feedback. I will investigate the cause and fix this strange bug.

@zuobiao-zhou zuobiao-zhou deleted the customize-interval branch September 15, 2024 04:12
@zuobiao-zhou zuobiao-zhou restored the customize-interval branch September 15, 2024 04:14
@zuobiao-zhou zuobiao-zhou reopened this Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend collector doc Improvements or additions to documentation good first pull request Good for newcomers improve pending
Projects
Development

Successfully merging this pull request may close these issues.

[Task] Customizable Refresh Intervals for Monitoring Metrics
2 participants