Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[manager]collectorApi unit test case and example #2306

Merged
merged 5 commits into from
Jul 20, 2024
Merged

[manager]collectorApi unit test case and example #2306

merged 5 commits into from
Jul 20, 2024

Conversation

jiangsh-ui
Copy link
Contributor

@jiangsh-ui jiangsh-ui commented Jul 18, 2024 •
edited
Loading

What's changed?

collectorApi unit test case and example

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

@jiangsh-ui
Copy link
Contributor Author

@tomsun28 Can you take a look at this pr?

@tomsun28 tomsun28 added the good first pull request Good for newcomers label Jul 20, 2024
tomsun28
tomsun28 approved these changes Jul 20, 2024
View reviewed changes
Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomsun28 tomsun28 merged commit be0de49 into apache:master Jul 20, 2024
3 checks passed
@jiangsh-ui jiangsh-ui deleted the collector-unitTest-feature-brach branch July 20, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomsun28 tomsun28 tomsun28 approved these changes

Assignees
No one assigned
Labels
backend good first pull request Good for newcomers
Projects
Apache HertzBeat (Incubating)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiangsh-ui @tomsun28