Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an i18n issue #2332

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Fixed an i18n issue #2332

merged 2 commits into from
Jul 22, 2024

Conversation

kerwin612
Copy link
Member

@kerwin612 kerwin612 commented Jul 22, 2024

What's changed?




From the above four lines of code, we can see that the [app] in the list data is all in lower-case;
Therefore, there will be a problem when the front-end tries to obtain i18n using an unprocessed (not uniformly converted to lower-case) [app].

{{ 'monitor.app.' + data.app | i18n }} / {{ 'monitor.availability' | i18n }}

Checklist

  • I have read the Contributing Guide
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

Add or update API

  • I have added the necessary e2e tests and all cases have passed.

Signed-off-by: Kerwin Bryant <kerwin612@qq.com>
@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 20.83%. Comparing base (e523625) to head (d6f5061).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2332      +/-   ##
============================================
+ Coverage     20.81%   20.83%   +0.02%     
  Complexity     1153     1153              
============================================
  Files           412      412              
  Lines         17522    17522              
  Branches       2311     2311              
============================================
+ Hits           3647     3651       +4     
+ Misses        13466    13462       -4     
  Partials        409      409              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yuluo-yx yuluo-yx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@tomsun28 tomsun28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomsun28 tomsun28 merged commit 497338e into master Jul 22, 2024
3 checks passed
@zqr10159 zqr10159 deleted the patch-57 branch September 23, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants