[type:fix] fix threshold rule modal not clear bug #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@Aias00 hi, in my test, the modal can be cleared after canceling the edit, but the form still cannot be cleared after clicking OK |
|
OK i will do more check later
…---- Replied Message ----
| From | ***@***.***> |
| Date | 07/22/2024 21:46 |
| To | apache/hertzbeat ***@***.***> |
| Cc | aias00 ***@***.***>,
Mention ***@***.***> |
| Subject | Re: [apache/hertzbeat] [type:fix] fix threshold rule modal not clear bug (PR #2340) |
@Aias00 hi, in my test, the modal can be cleared after canceling the edit, but the form still cannot be cleared after clicking OK
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
@LiuTianyou hi, i had checked again, and now the form will be cleared after clicking ok. pls check later |
LiuTianyou
approved these changes
Jul 23, 2024
|
👍🏻👍🏻👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
fix threshold rule modal not clear bug #2276
Checklist
Add or update API